fix: remove extra dot in extension

[mlaurencin]

Description of Change

Closes #35594 #35429

Removes an extra period from the extension portion of the dialog filter on Windows. This is not expected in Electron's implementation of filters, but was in place for Chromium's. Updates #34723

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Added support for Windows drop-down dialog extensions

[Prinzhorn]

I wonder if there's a technical limitation (I don't really do c/c++) or if GetRegistryDescriptionFromExtension and FormatFilterForExtensions can be unit tested? They do look very testable. I'm also curious why this and the previous PR didn't have any release notes, but maybe I'm missing something?

[mlaurencin]

@Prinzhorn Initially I didn’t add release notes as it was putting in place something standard to Windows functionality, but if people think one is warranted, I can certainly add one.

For unit testing, the issue did not arise from those functions, but rather in a misunderstanding of the difference in Chromium and Electron code paths. As for creating a test that would mimic the related issues, from what I can tell that would require manually switching between file types from the dropdown menu. I am a bit unsure as to how that sort of test can be constructed, but if someone has a suggestion, please let me know.

[Prinzhorn]

Initially I didn’t add release notes as it was putting in place something standard to Windows functionality, but if people think one is warranted, I can certainly add one.

From #34723 I thought this was fixing a behavior that was previously considered a bug. I personally go through all release notes when I upgrade Electron and thought the Electron team would enforce release notes for bug fixes, that's why I was asking. And this PR is also fixing/closing two issues, so I think there certainly need to be release notes.

As for creating a test that would mimic the related issues, from what I can tell that would require manually switching between file types from the dropdown menu. I am a bit unsure as to how that sort of test can be constructed, but if someone has a suggestion, please let me know.

Fair enough, maybe this can only be manually tested with reasonable effort. I'm certainly the wrong person to answer that.

[ckerr]

not ok 238 BrowserWindow module navigation events will-navigate event is triggered when a cross-origin iframe navigates _top

build-linux CI failure appears to be unrelated to PR

[ckerr]

Quick, let's merge it while everything's green!!

[release-clerk]

Release Notes Persisted

Added support for Windows drop-down dialog extensions

[trop]

I have automatically backported this PR to "20-x-y", please check out #35659

[trop]

I have automatically backported this PR to "19-x-y", please check out #35660

[trop]

I have automatically backported this PR to "18-x-y", please check out #35661

[mlaurencin]

/trop run backport-to 21-x-y

[trop]

The backport process for this PR has been manually initiated - sending your PR to 21-x-y!

[trop]

I have automatically backported this PR to "21-x-y", please check out #36027