fix: allow maximizing when window enters tablet mode with WCO #35617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you isolate the PIP change from touch mode change since they are different issues. Thanks! |
rzhao271
force-pushed
the
rzhao271/wco-max-fix
branch
from
1f7b412
to
ecec895
Compare
rzhao271
changed the title
deepak1556
changed the title
deepak1556
added
semver/patch
deepak1556
reviewed
Sep 12, 2022
Co-authored-by: Robo <hop2deep@gmail.com>
rzhao271
requested review from
deepak1556
and removed request for
codebytere
deepak1556
approved these changes
Sep 12, 2022
jkleinsc
approved these changes
Sep 13, 2022
|
Release Notes Persisted
|
This was referenced Sep 13, 2022
|
I have automatically backported this PR to "20-x-y", please check out #35663 |
|
I was unable to backport this PR to "19-x-y" cleanly; |
|
I have automatically backported this PR to "21-x-y", please check out #35664 |
trop
bot
added
needs-manual-bp/19-x-y
merged/21-x-y
5 tasks
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
…on#35617) * fix: Backport CL 3753528 for WCO * Update comment * Update shell/browser/ui/views/win_caption_button_container.cc Co-authored-by: Robo <hop2deep@gmail.com> Co-authored-by: Robo <hop2deep@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This change backports CL 3753528 to keep Electron's WCO behaviour for
WinCaptionButtonContainer::UpdateButtonsin sync with Chromium.Downstream issue: microsoft/vscode#159851
CC @deepak1556
Checklist
npm testpassesRelease Notes
Notes: Enable WCO maximize button when window enters tablet mode and is not already maximized.