fix: Set background for WCO container #35569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
added
semver/patch
|
Background of the container view should also be adjusted when user calls |
|
Added. |
codebytere
approved these changes
Sep 6, 2022
deepak1556
approved these changes
Sep 7, 2022
deepak1556
force-pushed
the
rzhao271/wco-bg-fix
branch
from
f1882c4
to
ffbebbd
Compare
|
Failing test is unrelated, merging. |
|
Release Notes Persisted
|
|
I have automatically backported this PR to "19-x-y", please check out #35610 |
This was referenced Sep 8, 2022
|
I have automatically backported this PR to "20-x-y", please check out #35611 |
|
I have automatically backported this PR to "21-x-y", please check out #35612 |
trop
bot
added
in-flight/20-x-y
and removed
target/20-x-y
target/21-x-y
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* fix: Set background for WCO container * Add background when invalidating as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #35312
Ref #35312 (comment)
Chromium was setting a background colour for the windows control overlay container, whereas we weren't. This PR copies the line so that we are also setting a background colour for the WCO container, which should avoid rendering glitches.
I'm currently on an RTL system language to work on another issue, so the WCO in the demo below is mirrored, but it shows that the gaps have been filled in with the overlay button colour.
CC @deepak1556
Checklist
npm testpassesRelease Notes
Notes: Added a background to the WCO container to avoid rendering glitches.