Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose content-bounds-updated event #35533

Merged
merged 5 commits into from Sep 13, 2022
Merged

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Aug 31, 2022

Description of Change

This exposes a new WebContents event, content-bounds-updated, which is called
when the page calls window.moveTo or window.resizeTo. It is possible to
prevent the default behavior of moving the window by calling
event.preventDefault().

Checklist

Release Notes

Notes: Added new WebContents event content-bounds-updated.

@nornagon nornagon added no-backport semver/minor backwards-compatible functionality labels Aug 31, 2022
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours api-review/requested 🗳 labels Aug 31, 2022
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM.

Is it possible to add a test for this?

@nornagon
Copy link
Member Author

nornagon commented Sep 1, 2022

tests added.

Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@nornagon nornagon merged commit 9f97c3e into main Sep 13, 2022
@nornagon nornagon deleted the content-bounds-updated branch September 13, 2022 17:49
@release-clerk
Copy link

release-clerk bot commented Sep 13, 2022

Release Notes Persisted

Added new WebContents event content-bounds-updated.

khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants