New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace scroll-touch* with generic input-event #35531
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron-cation
bot
added
new-pr 🌱
PR opened in the last 24 hours
api-review/requested 🗳
labels
Aug 31, 2022
3 tasks
i fixed the tests to use |
API LGTM |
codebytere
reviewed
Sep 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API LGTM
electron-cation
bot
added
api-review/approved ✅
and removed
api-review/requested 🗳
labels
Sep 21, 2022
Co-authored-by: Samuel Maddock <smaddock@salesforce.com>
nornagon
force-pushed
the
deprecate-scroll-touch-events
branch
from
September 26, 2022 22:02
532d1d5
to
c01b9c9
Compare
jkleinsc
approved these changes
Sep 27, 2022
Release Notes Persisted
|
3 tasks
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This adds a new event to WebContents,
input-event
, that exposes theunderlying WebInputEvent stream.
As written, this only outputs a generic "WebInputEvent" unless the event is a
keyboard event, in which case it outputs some more information. Ultimately we
should expose all information available for each type of WebInputEvent.
This supercedes the old
scroll-touch-edge
andscroll-touch-end
events, andreplaces
scroll-touch-begin
with a similar but not quite identical event.Specifically,
scroll-touch-begin
used to be emitted when the user placed twofingers down on the trackpad but before the touches had moved. Now it is only
emitted once the scroll gesture starts happening.
This somewhat overlaps with the
before-input-event
event on WebContents,which is similar but only exposes keyboard events, and allows preventing the
event from being processed, which this API does not.
Checklist
npm test
passesRelease Notes
Notes:
input-event
event.scroll-touch-*
events.