Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: webFrameMain.origin #35438

Merged
merged 3 commits into from Sep 1, 2022
Merged

feat: webFrameMain.origin #35438

merged 3 commits into from Sep 1, 2022

Conversation

nornagon
Copy link
Member

Description of Change

This adds webFrameMain.origin, which is useful for verifying the provenance
of about:blank child windows.

Checklist

Release Notes

Notes: Added webFrameMain.origin.

@nornagon nornagon added semver/minor backwards-compatible functionality target/20-x-y target/21-x-y PR should also be added to the "21-x-y" branch. labels Aug 24, 2022
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours api-review/requested 🗳 labels Aug 24, 2022
samuelmaddock
samuelmaddock suggested changes Aug 25, 2022
View reviewed changes
Copy link
Member

@samuelmaddock samuelmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change requests, but otherwise lgtm!

shell/browser/api/electron_api_web_frame_main.cc Show resolved Hide resolved
shell/browser/api/electron_api_web_frame_main.h Show resolved Hide resolved
spec/api-web-frame-main-spec.ts Show resolved Hide resolved
@samuelmaddock
Copy link
Member

API LGTM

zcbenz
zcbenz approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@codebytere codebytere mentioned this pull request Aug 29, 2022
Merged
ckerr
ckerr approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 31, 2022
@nornagon nornagon merged commit 6ad679f into main Sep 1, 2022
@nornagon nornagon deleted the webframe-origin branch September 1, 2022 00:41
@release-clerk
Copy link

release-clerk bot commented Sep 1, 2022

Release Notes Persisted

Added webFrameMain.origin.

This was referenced Sep 1, 2022
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Sep 1, 2022

I have automatically backported this PR to "21-x-y", please check out #35534

@trop trop bot added in-flight/21-x-y and removed target/21-x-y PR should also be added to the "21-x-y" branch. labels Sep 1, 2022
@trop
Copy link
Contributor

trop bot commented Sep 1, 2022

I have automatically backported this PR to "20-x-y", please check out #35535

kyrylo-hrechykhin pushed a commit to kyrylo-hrechykhin/electron that referenced this pull request Sep 1, 2022
@nornagon
feat: webFrameMain.origin (electron#35438)
3892e8b
@miniak
Copy link
Contributor

miniak commented Sep 2, 2022

/trop run backport-to 19-x-y

@trop
Copy link
Contributor

trop bot commented Sep 2, 2022

The backport process for this PR has been manually initiated - sending your PR to 19-x-y!

@trop
Copy link
Contributor

trop bot commented Sep 2, 2022

I was unable to backport this PR to "19-x-y" cleanly;
you will need to perform this backport manually.

miniak pushed a commit that referenced this pull request Sep 9, 2022
@nornagon @miniak
feat: webFrameMain.origin (#35438)
942a105
@miniak miniak mentioned this pull request Sep 9, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Sep 9, 2022

@miniak has manually backported this PR to "19-x-y", please check out #35624

miniak pushed a commit that referenced this pull request Sep 13, 2022
@nornagon @miniak
feat: webFrameMain.origin (#35438)
613ec9d
@samuelmaddock samuelmaddock mentioned this pull request Sep 13, 2022
Closed
5 tasks
ckerr pushed a commit that referenced this pull request Sep 15, 2022
@miniak @nornagon
feat: webFrameMain.origin (#35624)
c2d73ae 
feat: webFrameMain.origin (#35438)

Co-authored-by: Jeremy Rose <jeremya@chromium.org>
@trop trop bot added merged/19-x-y merged/21-x-y PR was merged to the "21-x-y" branch. and removed in-flight/19-x-y labels Sep 15, 2022
@commit-lint commit-lint bot mentioned this pull request Nov 30, 2022
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@nornagon @khalwa
feat: webFrameMain.origin (electron#35438)
422cb19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@zcbenz zcbenz zcbenz approved these changes

@samuelmaddock samuelmaddock samuelmaddock approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
api-review/requested 🗳 merged/21-x-y PR was merged to the "21-x-y" branch. semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nornagon @samuelmaddock @miniak @ckerr @zcbenz @MarshallOfSound