Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for Web Bluetooth pin pairing #35416

Merged
merged 7 commits into from Sep 26, 2022
Merged

feat: add support for Web Bluetooth pin pairing #35416

merged 7 commits into from Sep 26, 2022

Conversation

jkleinsc
Copy link
Contributor

@jkleinsc jkleinsc commented Aug 23, 2022 •
edited

Description of Change

https://chromium-review.googlesource.com/c/chromium/src/+/2841104 added support for providing a pin for bluetooth devices on Windows and Linux when required but we simply stubbed out this functionality on the chromium roll (#31317). This PR adds a new event bluetooth-pair-prompt to Session to allow developers to handle the request for a pin when pairing a bluetooth device.

Resolves #33111

Checklist

Release Notes

Notes: Added support for Web Bluetooth pin pairing on Linux and Windows

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 23, 2022
@jkleinsc jkleinsc added the semver/minor backwards-compatible functionality label Aug 23, 2022
@jkleinsc jkleinsc added target/19-x-y target/21-x-y PR should also be added to the "21-x-y" branch. and removed api-review/requested 🗳 labels Aug 23, 2022
@jkleinsc jkleinsc requested review from a team as code owners August 24, 2022 01:46
zcbenz
zcbenz reviewed Aug 25, 2022
View reviewed changes
docs/api/session.md Outdated Show resolved Hide resolved
@jkleinsc jkleinsc mentioned this pull request Aug 25, 2022
Closed
3 tasks
nornagon
nornagon reviewed Aug 26, 2022
View reviewed changes
docs/api/session.md Outdated Show resolved Hide resolved
docs/api/session.md Outdated Show resolved Hide resolved
docs/api/session.md Outdated Show resolved Hide resolved
shell/browser/bluetooth/electron_bluetooth_delegate.cc Outdated Show resolved Hide resolved
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 30, 2022
@ckerr ckerr requested a review from nornagon September 15, 2022 21:24
@jkleinsc jkleinsc removed the wip ⚒ label Sep 19, 2022
@jkleinsc jkleinsc requested a review from ckerr September 19, 2022 22:57
ckerr
ckerr reviewed Sep 20, 2022
View reviewed changes
docs/api/session.md Outdated Show resolved Hide resolved
docs/api/session.md Outdated Show resolved Hide resolved
docs/api/session.md Show resolved Hide resolved
docs/api/session.md Outdated Show resolved Hide resolved
itsananderson
itsananderson reviewed Sep 20, 2022
View reviewed changes
docs/api/session.md Outdated Show resolved Hide resolved
@jkleinsc jkleinsc changed the title feat: add bluetooth-pair-prompt event feat: add support for Web Bluetooth pin pairing Sep 20, 2022
ckerr
ckerr reviewed Sep 20, 2022
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

erickzhao
erickzhao reviewed Sep 20, 2022
View reviewed changes
docs/api/session.md Outdated Show resolved Hide resolved
docs/api/session.md Outdated Show resolved Hide resolved
docs/api/session.md Outdated Show resolved Hide resolved
docs/api/session.md Outdated Show resolved Hide resolved
docs/api/session.md Show resolved Hide resolved
shell/browser/bluetooth/electron_bluetooth_delegate.cc Outdated Show resolved Hide resolved
shell/browser/bluetooth/electron_bluetooth_delegate.cc Outdated Show resolved Hide resolved
ckerr
ckerr reviewed Sep 21, 2022
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Archaeologist is showing some changes that seem unrelated to the PR.

I think this will go away once the PR is updated to be in sync with main but thought I'd point it out in case it's an actual issue

erickzhao
erickzhao approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@codebytere codebytere added semver/minor backwards-compatible functionality and removed semver/minor backwards-compatible functionality labels Sep 26, 2022
@codebytere codebytere added semver/minor backwards-compatible functionality and removed semver/minor backwards-compatible functionality api-review/requested 🗳 labels Sep 26, 2022
@jkleinsc jkleinsc merged commit 697a219 into main Sep 26, 2022
@jkleinsc jkleinsc deleted the add-bluetooth-pin-support branch September 26, 2022 14:19
@release-clerk
Copy link

release-clerk bot commented Sep 26, 2022

Release Notes Persisted

Added support for Web Bluetooth pin pairing on Linux and Windows

@trop
Copy link
Contributor

trop bot commented Sep 26, 2022

I was unable to backport this PR to "19-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/19-x-y label Sep 26, 2022
@trop
Copy link
Contributor

trop bot commented Sep 26, 2022

I was unable to backport this PR to "20-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot mentioned this pull request Sep 26, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Sep 26, 2022

I have automatically backported this PR to "21-x-y", please check out #35818

@trop trop bot added in-flight/21-x-y merged/21-x-y PR was merged to the "21-x-y" branch. and removed target/21-x-y PR should also be added to the "21-x-y" branch. in-flight/21-x-y labels Sep 26, 2022
@commit-lint commit-lint bot mentioned this pull request Jan 25, 2023
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@jkleinsc @ckerr
@erickzhao @khalwa
feat: add support for Web Bluetooth pin pairing (electron#35416)
a371a2f 
* feat: add bluetooth pairing handler

* Update docs/api/session.md

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* Update docs/api/session.md

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* docs: update based on review

* Apply suggestions from code review

Co-authored-by: Erick Zhao <erick@hotmail.ca>
Co-authored-by: Charles Kerr <charles@charleskerr.com>

* chore: update docs per review

* chore: cleanup callback per review

Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Erick Zhao <erick@hotmail.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz left review comments

@ckerr ckerr ckerr approved these changes

@itsananderson itsananderson itsananderson approved these changes

@erickzhao erickzhao erickzhao approved these changes

@nornagon nornagon Awaiting requested review from nornagon

Assignees
No one assigned
Labels
api-review/requested 🗳 merged/21-x-y PR was merged to the "21-x-y" branch. semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Web Bluetooth PIN pairing fails on Windows
8 participants
@jkleinsc @ckerr @nornagon @itsananderson @zcbenz @erickzhao @miniak @codebytere