Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undefined details.requestingUrl from session.setPermissionCheckHandler #35408

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Aug 23, 2022

Backport of #35281

See that PR for details.

Notes: fix undefined details.requestingUrl from session.setPermissionCheckHandler

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 23, 2022
@trop trop bot requested a review from deepak1556 August 23, 2022 01:26
@trop trop bot added 20-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Aug 23, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 23, 2022
@deepak1556
Copy link
Member

deepak1556 commented Aug 23, 2022

Depends on #35358

@codebytere codebytere force-pushed the trop/20-x-y-bp-fix-undefined-details-requestingurl-from-session-setpermissioncheckhandler-1661217981983 branch from 9ec61d3 to 49ab9a4 Compare August 23, 2022 09:43
@jkleinsc jkleinsc force-pushed the trop/20-x-y-bp-fix-undefined-details-requestingurl-from-session-setpermissioncheckhandler-1661217981983 branch from 49ab9a4 to 8200929 Compare August 23, 2022 14:29
@codebytere codebytere merged commit 3795fba into 20-x-y Aug 24, 2022
@codebytere codebytere deleted the trop/20-x-y-bp-fix-undefined-details-requestingurl-from-session-setpermissioncheckhandler-1661217981983 branch August 24, 2022 09:42
@release-clerk
Copy link

release-clerk bot commented Aug 24, 2022

Release Notes Persisted

fix undefined details.requestingUrl from session.setPermissionCheckHandler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
20-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants