New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: WebAuthn Discoverable Credential (Resident Credential) #35374
Merged
MarshallOfSound
merged 12 commits into
electron:main
from
matthewloft:defect-33353-Webauthn-discoverable-credential
Sep 20, 2022
Merged
fix: WebAuthn Discoverable Credential (Resident Credential) #35374
MarshallOfSound
merged 12 commits into
electron:main
from
matthewloft:defect-33353-Webauthn-discoverable-credential
Sep 20, 2022
Commits on Aug 15, 2022
-
fix: WebAuthn Discoverable Credential (Resident Credential) electron#…
…33353 Enables support for Webauthn discoverable credentials (aka resident credentials). This allows users to authenticate without first having to select or type a username. To decide if discoverable credentials are supported, the class 'AuthenticatorCommon', in the chrome content code, indirectly calls the method 'context::WebAuthenticationDelegate.SupportsResidentKeys(..)'. The default implementation of this returns false, leaving it up to specific implementations to override. This change adds a new class 'ElectronWebAuthenticationDelegate' to subclass 'WebAuthenticationDelegate' and override the behaviour of the 'SupportsResidentKeys' method to return true. The implementation is copied from the Chrome browser equivalent 'ChromeWebAuthenticationDelegate', though the chrome class includes other methods that don't seem to be required for this functionality. The 'ElectronContentClient' class was also updated to store an instance of 'ElectronWebAuthenticationDelegate', and to provide an accessor method, GetWebAuthenticationDelegate().
Configuration menu - View commit details
-
Copy full SHA for e62adbd - Browse repository at this point
Copy the full SHA e62adbdView commit details
Commits on Aug 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for cde3049 - Browse repository at this point
Copy the full SHA cde3049View commit details -
Configuration menu - View commit details
-
Copy full SHA for c009f7f - Browse repository at this point
Copy the full SHA c009f7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ae82279 - Browse repository at this point
Copy the full SHA ae82279View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6ee135 - Browse repository at this point
Copy the full SHA c6ee135View commit details
Commits on Aug 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 05fd98a - Browse repository at this point
Copy the full SHA 05fd98aView commit details
Commits on Aug 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 1d2a5a6 - Browse repository at this point
Copy the full SHA 1d2a5a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 10e20e2 - Browse repository at this point
Copy the full SHA 10e20e2View commit details
Commits on Aug 24, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6b0deb0 - Browse repository at this point
Copy the full SHA 6b0deb0View commit details
Commits on Aug 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 0060d0b - Browse repository at this point
Copy the full SHA 0060d0bView commit details
Commits on Sep 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 706f31e - Browse repository at this point
Copy the full SHA 706f31eView commit details
Commits on Sep 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for d97a21e - Browse repository at this point
Copy the full SHA d97a21eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.