Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: WebAuthn Discoverable Credential (Resident Credential) #35374

Commits on Aug 15, 2022

  1. fix: WebAuthn Discoverable Credential (Resident Credential) electron#…

    …33353
    
    Enables support for Webauthn discoverable credentials (aka resident
    credentials). This allows users to authenticate without first having to
    select or type a username.
    
    To decide if discoverable credentials are supported, the class
    'AuthenticatorCommon', in the chrome content code, indirectly calls the
    method 'context::WebAuthenticationDelegate.SupportsResidentKeys(..)'.
    The default implementation of this returns false, leaving it up to
    specific implementations to override.
    
    This change adds a new class 'ElectronWebAuthenticationDelegate' to
    subclass 'WebAuthenticationDelegate' and override the behaviour of the
    'SupportsResidentKeys' method to return true.
    The implementation is copied from the Chrome browser equivalent
    'ChromeWebAuthenticationDelegate', though the chrome class includes
    other methods that don't seem to be required for this functionality.
    
    The 'ElectronContentClient' class was also updated to store an instance
    of 'ElectronWebAuthenticationDelegate', and to provide an accessor
    method, GetWebAuthenticationDelegate().
    matthewloft committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    e62adbd View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2022

  1. Configuration menu
    Copy the full SHA
    cde3049 View commit details
    Browse the repository at this point in the history
  2. style: comment cleanup

    matthewloft committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    c009f7f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ae82279 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c6ee135 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. Configuration menu
    Copy the full SHA
    05fd98a View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2022

  1. Configuration menu
    Copy the full SHA
    1d2a5a6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    10e20e2 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2022

  1. Configuration menu
    Copy the full SHA
    6b0deb0 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2022

  1. Configuration menu
    Copy the full SHA
    0060d0b View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. Configuration menu
    Copy the full SHA
    706f31e View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2022

  1. Configuration menu
    Copy the full SHA
    d97a21e View commit details
    Browse the repository at this point in the history