Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: IPC emit order in -ipc-ports handler #35320

Merged
merged 1 commit into from Aug 16, 2022
Merged

fix: IPC emit order in -ipc-ports handler #35320

merged 1 commit into from Aug 16, 2022

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Aug 12, 2022 •
edited

Description of Change

Follow-up to #34959.
The order in this case does not match the documentation: https://github.com/electron/electron/blob/main/docs/api/web-frame-main.md#frameipc-readonly

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 12, 2022
@miniak miniak requested a review from nornagon August 12, 2022 13:58
@miniak miniak added the semver/patch backwards-compatible bug fixes label Aug 12, 2022
@miniak miniak self-assigned this Aug 12, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 13, 2022
@nornagon
Copy link
Member

Needs to be backported to 21-x-y if #35231 lands.

@zcbenz zcbenz merged commit e85450b into main Aug 16, 2022
@zcbenz zcbenz deleted the miniak/fix-ipc-emit-order branch August 16, 2022 02:21
@release-clerk
Copy link

release-clerk bot commented Aug 16, 2022

No Release Notes

@miniak
Copy link
Contributor Author

miniak commented Aug 17, 2022

/trop run backport-to 21-x-y

@trop
Copy link
Contributor

trop bot commented Aug 17, 2022

The backport process for this PR has been manually initiated - sending your PR to 21-x-y!

@trop trop bot mentioned this pull request Aug 17, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Aug 17, 2022

I have automatically backported this PR to "21-x-y", please check out #35364

@trop trop bot added merged/21-x-y PR was merged to the "21-x-y" branch. and removed in-flight/21-x-y labels Aug 19, 2022
@commit-lint commit-lint bot mentioned this pull request Oct 27, 2022
Open
schetle pushed a commit to schetle/electron that referenced this pull request Nov 3, 2022
@miniak @schetle
fix: IPC emit order in -ipc-ports handler (electron#35320)
aa30c0c 
Co-authored-by: Milan Burda <miburda@microsoft.com>
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@miniak @khalwa
fix: IPC emit order in -ipc-ports handler (electron#35320)
9496b79 
Co-authored-by: Milan Burda <miburda@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@zcbenz zcbenz zcbenz approved these changes

Assignees

@miniak miniak

Labels
merged/21-x-y PR was merged to the "21-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miniak @nornagon @zcbenz