Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support serialPort.forget() #35310

Merged
merged 1 commit into from Oct 18, 2022
Merged

feat: support serialPort.forget() #35310

merged 1 commit into from Oct 18, 2022

Conversation

codebytere
Copy link
Member

Description of Change

Refs CL:3560622.

This PR adds support for serialPort.forget() as well as a new event serial-port-revoked emitted when a given origin is revoked.

Checklist

Release Notes

Notes: Added support for serialPort.forget() as well as a new event serial-port-revoked emitted when a given origin is revoked.

@codebytere codebytere added semver/minor backwards-compatible functionality api-review/requested 🗳 labels Aug 11, 2022
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed api-review/requested 🗳 labels Aug 11, 2022
@codebytere codebytere changed the title feat: supportserialPort.revoke() feat: support serialPort.revoke() Aug 11, 2022
@codebytere codebytere mentioned this pull request Aug 11, 2022
Merged
Base automatically changed from fix-opening-serial-port to main August 15, 2022 15:49
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 18, 2022
@codebytere codebytere force-pushed the enable-serialport-forget branch 3 times, most recently from 6c038fd to 42dd514 Compare August 30, 2022 11:50
@codebytere codebytere changed the title feat: support serialPort.revoke() feat: support serialPort.forget() Aug 30, 2022
@codebytere codebytere marked this pull request as ready for review August 30, 2022 11:51
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 30, 2022
ckerr
ckerr reviewed Aug 31, 2022
View reviewed changes
shell/browser/serial/serial_chooser_context.h Show resolved Hide resolved
shell/browser/serial/serial_chooser_context.cc Outdated Show resolved Hide resolved
shell/browser/serial/serial_chooser_context.cc Outdated Show resolved Hide resolved
shell/browser/serial/serial_chooser_context.cc Outdated Show resolved Hide resolved
shell/browser/serial/serial_chooser_context.cc Outdated Show resolved Hide resolved
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 6, 2022
@jkleinsc jkleinsc added semver/minor backwards-compatible functionality and removed semver/minor backwards-compatible functionality labels Sep 26, 2022
@codebytere codebytere force-pushed the enable-serialport-forget branch 2 times, most recently from be1dcd8 to c570777 Compare September 27, 2022 09:37
@codebytere codebytere force-pushed the enable-serialport-forget branch 3 times, most recently from 3c08e81 to 43c921c Compare October 4, 2022 14:30
@codebytere codebytere added the target/22-x-y PR should also be added to the "22-x-y" branch. label Oct 4, 2022
@patchup patchup bot requested a review from a team as a code owner October 4, 2022 14:43
@codebytere
Copy link
Member Author

@jkleinsc i think this should be good for final review!

jkleinsc
jkleinsc approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment •
edited by codebytere

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@nornagon
Copy link
Member

@jkleinsc I think you typo'd the LGTM

also, API LGTM

@codebytere
Copy link
Member Author

Merging with two LGTMs.

@codebytere codebytere merged commit 4310468 into main Oct 18, 2022
@codebytere codebytere deleted the enable-serialport-forget branch October 18, 2022 09:22
@release-clerk
Copy link

release-clerk bot commented Oct 18, 2022

Release Notes Persisted

Added support for serialPort.forget() as well as a new event serial-port-revoked emitted when a given origin is revoked.

@trop trop bot mentioned this pull request Oct 18, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Oct 18, 2022

I have automatically backported this PR to "22-x-y", please check out #36062

@trop trop bot added in-flight/22-x-y merged/22-x-y PR was merged to the "22-x-y" branch. and removed target/22-x-y PR should also be added to the "22-x-y" branch. in-flight/22-x-y labels Oct 18, 2022
brjsp added a commit to brjsp/electron that referenced this pull request Dec 2, 2022
@brjsp
chore: reland “fix ambiguous reference gcc compile error”
7342506 
This is a reland of electron#35714. The broken code got reintroduced in electron#35310 due to a mismerge.
@brjsp brjsp mentioned this pull request Dec 2, 2022
Merged
nornagon pushed a commit that referenced this pull request Dec 13, 2022
@brjsp
chore: reland “fix ambiguous reference gcc compile error” (#36544)
1432f9b 
This is a reland of #35714. The broken code got reintroduced in #35310 due to a mismerge.
@commit-lint commit-lint bot mentioned this pull request Feb 13, 2023
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@codebytere @khalwa
feat: support serialPort.forget() (electron#35310)
72e7101 
feat: enable serialPort.revoke()
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@brjsp @khalwa
chore: reland “fix ambiguous reference gcc compile error” (electron#3…
8a9bfa3 
…6544)

This is a reland of electron#35714. The broken code got reintroduced in electron#35310 due to a mismerge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound left review comments

@jkleinsc jkleinsc jkleinsc approved these changes

@ckerr ckerr Awaiting requested review from ckerr

Assignees
No one assigned
Labels
api-review/requested 🗳 merged/22-x-y PR was merged to the "22-x-y" branch. semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@codebytere @nornagon @ckerr @jkleinsc @MarshallOfSound