Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: modify file extension generation on Windows #35173

Merged
merged 12 commits into from Aug 2, 2022
Merged

fix: modify file extension generation on Windows #35173

merged 12 commits into from Aug 2, 2022

Commits on Aug 2, 2022

  1. fix: modify file extension generation on Windows

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Aug 2, 2022
    Copy the full SHA
    d8890ab View commit details
    Browse the repository at this point in the history

  2. modify includes

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Aug 2, 2022
    Copy the full SHA
    5c2af2d View commit details
    Browse the repository at this point in the history

  3. include vector in header

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Aug 2, 2022
    Copy the full SHA
    d87fbf5 View commit details
    Browse the repository at this point in the history

  4. add win build flags

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Aug 2, 2022
    Copy the full SHA
    2c9eddc View commit details
    Browse the repository at this point in the history

  5. remove hardcoded strings

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Aug 2, 2022
    Copy the full SHA
    071c0d8 View commit details
    Browse the repository at this point in the history

  6. Update shell/browser/electron_download_manager_delegate.h 

    Co-authored-by: Charles Kerr <charles@charleskerr.com>
    @mlaurencin @ckerr @electron-bot
    2 people authored and electron-bot committed Aug 2, 2022
    Copy the full SHA
    ab0ea45 View commit details
    Browse the repository at this point in the history

  7. fix string manipulation and function definitions

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Aug 2, 2022
    Copy the full SHA
    6cf38d8 View commit details
    Browse the repository at this point in the history

  8. Update electron_download_manager_delegate.h

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Aug 2, 2022
    Copy the full SHA
    a3e7f95 View commit details
    Browse the repository at this point in the history

  9. convert to std::string and modify for electron

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Aug 2, 2022
    Copy the full SHA
    f1cd3ac View commit details
    Browse the repository at this point in the history

  10. Update shell/browser/electron_download_manager_delegate.cc 

    Co-authored-by: Charles Kerr <charles@charleskerr.com>
    @mlaurencin @ckerr @electron-bot
    2 people authored and electron-bot committed Aug 2, 2022
    Copy the full SHA
    a5c299b View commit details
    Browse the repository at this point in the history

  11. remove vector include and update conversion

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Aug 2, 2022
    Copy the full SHA
    d736cc3 View commit details
    Browse the repository at this point in the history

  12. add vectr include for lint

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Aug 2, 2022
    Copy the full SHA
    b935367 View commit details
    Browse the repository at this point in the history