Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fixed outdated documentation (uploading to App Store) #35116

Merged
merged 2 commits into from Nov 1, 2022
Merged

docs: Fixed outdated documentation (uploading to App Store) #35116

merged 2 commits into from Nov 1, 2022

Conversation

gabi200
Copy link
Contributor

@gabi200 gabi200 commented Jul 28, 2022 •
edited by codebytere

Description of Change

  • replaced mention of Application Loader with Apple Transporter, its replacement
  • replaced mention of iTunes Connect with App Store Connect
  • updated link for creating a record

Fixes #35115

Checklist

Release Notes

Notes: none

@welcome
Copy link

welcome bot commented Jul 28, 2022

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 28, 2022
@gabi200 gabi200 changed the title Fixed outdated documentation (uploading to App Store) docs: Fixed outdated documentation (uploading to App Store) Jul 28, 2022
@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes labels Jul 28, 2022
@gabi200 gabi200 mentioned this pull request Jul 28, 2022
Closed
@VerteDinde
Copy link
Member

@gabi200 Could you please rebase with main and push up to kick off CI again? The lint step is currently stuck; a force push should fix it 🙇‍♀️

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 29, 2022
@codebytere codebytere added target/20-x-y target/21-x-y PR should also be added to the "21-x-y" branch. and removed no-backport labels Aug 4, 2022
codebytere
codebytere reviewed Aug 8, 2022
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint is failing - https://app.circleci.com/pipelines/github/electron/electron/56449/workflows/6cf35241-cd5b-43ab-a520-76bb7daf7cfd/jobs/1285632

gabi200 and others added 2 commits August 25, 2022 12:24
@gabi200 @codebytere
Updated docs on uploading
2663352 
- replaced mention of Application Loader with Apple Transporter, its replacement
- replaced mention of iTunes Connect with App Store Connect
- updated link for creating a record
@zcbenz @codebytere
Update mac-app-store-submission-guide.md
0bd6c64
@jkleinsc jkleinsc added the target/22-x-y PR should also be added to the "22-x-y" branch. label Sep 28, 2022
@jkleinsc
Copy link
Contributor

jkleinsc commented Nov 1, 2022

Merging as CI failure unrelated to PR change.

@jkleinsc jkleinsc merged commit 71b8804 into electron:main Nov 1, 2022
@welcome
Copy link

welcome bot commented Nov 1, 2022

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Nov 1, 2022

No Release Notes

This was referenced Nov 1, 2022
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Nov 1, 2022

I have automatically backported this PR to "20-x-y", please check out #36211

@trop trop bot added the in-flight/20-x-y label Nov 1, 2022
@trop trop bot removed the target/20-x-y label Nov 1, 2022
@trop
Copy link
Contributor

trop bot commented Nov 1, 2022

I have automatically backported this PR to "21-x-y", please check out #36212

@trop
Copy link
Contributor

trop bot commented Nov 1, 2022

I have automatically backported this PR to "22-x-y", please check out #36213

@trop trop bot added in-flight/21-x-y merged/22-x-y PR was merged to the "22-x-y" branch. merged/21-x-y PR was merged to the "21-x-y" branch. and removed target/21-x-y PR should also be added to the "21-x-y" branch. target/22-x-y PR should also be added to the "22-x-y" branch. in-flight/22-x-y labels Nov 1, 2022
@commit-lint commit-lint bot mentioned this pull request Feb 21, 2023
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@gabi200 @zcbenz @khalwa
docs: Fixed outdated documentation (uploading to App Store) (electron…
1ccbfbd 
…#35116)

* Updated docs on uploading 

- replaced mention of Application Loader with Apple Transporter, its replacement
- replaced mention of iTunes Connect with App Store Connect
- updated link for creating a record

* Update mac-app-store-submission-guide.md

Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
documentation 📓 merged/21-x-y PR was merged to the "21-x-y" branch. merged/22-x-y PR was merged to the "22-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Update Mac App Store submission documentation
5 participants
@gabi200 @VerteDinde @jkleinsc @codebytere @zcbenz