chore: cherry-pick 3466cc056b05 from pdfium #35099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppontes
added
18-x-y
backport-check-skip
electron-cation
bot
added
new-pr 🌱
ppontes
force-pushed
the
cherry-pick/18-x-y/pdfium/3466cc056b05
branch
from
25458a5
to
8381d80
Compare
ppontes
force-pushed
the
cherry-pick/18-x-y/pdfium/3466cc056b05
branch
from
8381d80
to
ea1e43e
Compare
jkleinsc
approved these changes
Jul 28, 2022
|
Merging as lint failure is unrelated to PR and fixed via #35105 |
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
M102: Retain nodes when manipulating their dictionaries in CPDF_NameTree.
-- Pass retain ptrs consistently in a few other places.
Bug: chromium:1335861
Change-Id: If23cf6b6ec39ef02384beaa6745e1c7256160cba
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/94430
Reviewed-by: Lei Zhang thestig@chromium.org
Commit-Queue: Tom Sepez tsepez@chromium.org
(cherry picked from commit ebebb757c1f210ccc16e0cb2b425860a141a4e9f)
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/95271
Reviewed-by: Nigi nigi@chromium.org
Notes: Security: backported fix for CVE-2022-2478.