fix: use win_clang_x64 binary for x86 extract symbols #35078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerteDinde
added
semver/patch
VerteDinde
changed the title
MarshallOfSound
approved these changes
Jul 26, 2022
miniak
approved these changes
Jul 27, 2022
deepak1556
approved these changes
Jul 27, 2022
|
Merging given the release builds are green 👏 |
|
Release Notes Persisted
|
This was referenced Jul 27, 2022
|
I was unable to backport this PR to "18-x-y" cleanly; |
|
I have automatically backported this PR to "19-x-y", please check out #35090 |
|
I have automatically backported this PR to "20-x-y", please check out #35091 |
|
@VerteDinde has manually backported this PR to "18-x-y", please check out #35096 |
VerteDinde
added a commit
that referenced
this pull request
Jul 27, 2022
deepak1556
pushed a commit
that referenced
this pull request
Jul 28, 2022
schetle
pushed a commit
to schetle/electron
that referenced
this pull request
Nov 3, 2022
fix: use win_clang_x64 for x86 extract symbols
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
fix: use win_clang_x64 for x86 extract symbols
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Addresses #34413
We're currently experiencing build failures on main, 20-x-y and 18-x-y because the ia32 symbol generation is running out of virtual memory space. This PR uses the win_clang_x64 binary to extract/generate electron symbols for Windows x86.
Note: This issue isn't currently affecting 19-x-y, but it was introduced into 18-x-y by a backported Chromium roll. Adding this change to 19-x-y will protect us against a potential future breakage in that branch.
Checklist
npm testpassesRelease Notes
Notes: Fixed symbol generation on 32-bit Windows release builds.