Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cherry-pick ecad352cd614 from chromium #35053

Merged
merged 4 commits into from Nov 28, 2022
Merged

chore: cherry-pick ecad352cd614 from chromium #35053

merged 4 commits into from Nov 28, 2022

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jul 25, 2022

Backport of #34689

See that PR for details.

Notes: Security: backported fix for 1333333.

@trop trop bot requested review from a team as code owners July 25, 2022 22:44
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 25, 2022
@trop trop bot requested a review from nornagon July 25, 2022 22:44
@trop trop bot mentioned this pull request Jul 25, 2022
Merged
@trop trop bot added 19-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jul 25, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 25, 2022
@nornagon nornagon mentioned this pull request Jul 25, 2022
Closed
jkleinsc
jkleinsc previously requested changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch fails to apply

@miniak miniak requested a review from jkleinsc November 25, 2022 05:03
@VerteDinde VerteDinde merged commit de3776f into 19-x-y Nov 28, 2022
@VerteDinde VerteDinde deleted the trop/19-x-y-bp-chore-cherry-pick-ecad352cd614-from-chromium-1658789078687 branch November 28, 2022 15:29
@release-clerk
Copy link

release-clerk bot commented Nov 28, 2022

Release Notes Persisted

Security: backported fix for 1333333.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VerteDinde VerteDinde VerteDinde approved these changes

@ppontes ppontes ppontes approved these changes

@nornagon nornagon Awaiting requested review from nornagon

@jkleinsc jkleinsc Awaiting requested review from jkleinsc

Assignees
No one assigned
Labels
19-x-y backport This is a backport PR security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jkleinsc @VerteDinde @ppontes @nornagon @miniak