Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: UtilityProcess API #34980
feat: UtilityProcess API #34980
Changes from all commits
1f90147
8d6735e
d09f507
7adacda
f74d84d
a4caadb
ebbd3e5
fe7d6d5
5e08d9f
36cb34a
906428e
0db19ab
9bed786
489d3ac
f1393cd
1ce8398
540f067
965c5e3
5cb954d
76d398f
c3dff10
c8010a8
c5f131f
356bf25
c04d850
328ce01
4a3a579
e3b4c22
1b3ac3f
8793136
6430fc8
9b2c4c8
40a545b
581bcc9
09b7ba8
6a3c11c
5aebc0b
d7df0c0
98ac626
6616a24
82c6114
d33b0b0
014d6e8
a82d322
77eab25
8632413
f6b160a
a8c0069
c806238
e8f8dd8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Node.js defaults this to
process.execArgv
. What do we default it to?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can default to
process.execArgv
, there are two issuesprocess.execArgv
in the main process, always returns[]
electron/shell/common/node_bindings.cc
Lines 211 to 215 in 7493062
Can we leave the default for this option to be
[]
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine for the default to be whatever, but we should document what it is, & what (kind of) options can be passed here.