docs: new main -> renderers messageChannel example #34978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron-cation
bot
added
documentation 📓
semver/patch
codebytere
requested changes
Jul 20, 2022
There was a problem hiding this comment.
Seeing a number of lint failures: https://app.circleci.com/pipelines/github/electron/electron/55742/workflows/ea7328b0-cb5d-4e33-826c-2404b21c9d39/jobs/1270751
erickzhao
reviewed
Jul 20, 2022
Co-authored-by: Erick Zhao <erick@hotmail.ca>
VerteDinde
approved these changes
Jul 22, 2022
zcbenz
approved these changes
Jul 26, 2022
codebytere
approved these changes
Jul 29, 2022
|
No Release Notes |
This was referenced Jul 29, 2022
|
I have automatically backported this PR to "18-x-y", please check out #35133 |
|
I have automatically backported this PR to "20-x-y", please check out #35134 |
|
I have automatically backported this PR to "19-x-y", please check out #35135 |
schetle
pushed a commit
to schetle/electron
that referenced
this pull request
Nov 3, 2022
* docs: new main -> renderers messageChannel example * consistent use of your * fix a typo * linting * markdown linting * Update docs/tutorial/message-ports.md Co-authored-by: Erick Zhao <erick@hotmail.ca> * update code example headings, reference contextIsolation example * remove nodeIntegration: false from browserWindows * rename "messagePort" to "electronMessagePort" for compatibility Co-authored-by: Erick Zhao <erick@hotmail.ca>
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* docs: new main -> renderers messageChannel example * consistent use of your * fix a typo * linting * markdown linting * Update docs/tutorial/message-ports.md Co-authored-by: Erick Zhao <erick@hotmail.ca> * update code example headings, reference contextIsolation example * remove nodeIntegration: false from browserWindows * rename "messagePort" to "electronMessagePort" for compatibility Co-authored-by: Erick Zhao <erick@hotmail.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Added a code example describing how to set up a
messageChannelbetween two renderers from inside of main.Checklist
Release Notes
Notes: none