Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 763d847f1e5a from webrtc #34882

Merged
merged 2 commits into from Jul 12, 2022

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Jul 11, 2022

[M102] Do not allow simulcast to be turned off using SDP munging

This is an error that puts the PC into an inconsistent state, so
causing a crash is the right thing to do.

(cherry picked from commit 3fe8b0d9a980642ee5ebb1f9e429378b063c1f07)
TBR=hta@webrtc.org

Bug: chromium:1341043
Change-Id: Ie1eb89400ad87f0c83634b7073236b07e92ec7ab
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267281
Reviewed-by: Mirko Bonadei mbonadei@webrtc.org
Reviewed-by: Henrik Boström hbos@webrtc.org
Commit-Queue: Harald Alvestrand hta@webrtc.org
Cr-Original-Commit-Position: refs/heads/main@{#37391}
No-Presubmit: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267427
Commit-Queue: Taylor Brandstetter deadbeef@webrtc.org
Reviewed-by: Guido Urdaneta guidou@webrtc.org
Reviewed-by: Taylor Brandstetter deadbeef@webrtc.org
Cr-Commit-Position: refs/branch-heads/5005@{#9}
Cr-Branched-From: 8f9b44ba38c134e1c69126196e4d9e566ca5d5e3-refs/heads/main@{#36552}

Notes: Backported fix for CVE-2022-2294.

@ppontes ppontes requested review from a team as code owners July 11, 2022 18:44
@ppontes ppontes added 18-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes labels Jul 11, 2022
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Jul 11, 2022
@jkleinsc jkleinsc merged commit a70431f into 18-x-y Jul 12, 2022
@jkleinsc jkleinsc deleted the cherry-pick/18-x-y/webrtc/763d847f1e5a branch July 12, 2022 00:08
@release-clerk
Copy link

release-clerk bot commented Jul 12, 2022

Release Notes Persisted

Backported fix for CVE-2022-2294.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
18-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants