Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: safer check for WCO button updates #34833

Merged
merged 1 commit into from Jul 11, 2022
Merged

fix: safer check for WCO button updates #34833

merged 1 commit into from Jul 11, 2022

Conversation

codebytere
Copy link
Member

Description of Change

Refs #34677.

Fixes a potential crash when changing window settings after initializing WCO with an invalid titleBarStyle. We need both to ensure that the overlay has been set and also that the titleBarStyle is valid for the platform.

Checklist

Release Notes

Notes: Fixed a potential crash when changing window settings after initializing WCO with an invalid titleBarStyle.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/18-x-y labels Jul 7, 2022
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 7, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 8, 2022
clavin
clavin approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@clavin clavin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

One extra thought: is there anything we can do about renaming these methods to make it harder to mess this up in the future?

@codebytere codebytere merged commit 2eb0e5d into main Jul 11, 2022
@codebytere codebytere deleted the safer-check branch July 11, 2022 09:45
@release-clerk
Copy link

release-clerk bot commented Jul 11, 2022

Release Notes Persisted

Fixed a potential crash when changing window settings after initializing WCO with an invalid titleBarStyle.

This was referenced Jul 11, 2022
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Jul 11, 2022

I have automatically backported this PR to "18-x-y", please check out #34873

@trop
Copy link
Contributor

trop bot commented Jul 11, 2022

I have automatically backported this PR to "19-x-y", please check out #34874

@trop
Copy link
Contributor

trop bot commented Jul 11, 2022

I have automatically backported this PR to "20-x-y", please check out #34875

@miniak
Copy link
Contributor

miniak commented Jul 22, 2022

/trop run backport-to 17-x-y

@trop
Copy link
Contributor

trop bot commented Jul 22, 2022

The backport process for this PR has been manually initiated - sending your PR to 17-x-y!

@trop trop bot mentioned this pull request Jul 22, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Jul 22, 2022

I have automatically backported this PR to "17-x-y", please check out #35031

@commit-lint commit-lint bot mentioned this pull request Sep 13, 2022
Open
schetle pushed a commit to schetle/electron that referenced this pull request Nov 3, 2022
@codebytere @schetle
fix: safer check for WCO button updates (electron#34833)
4dc7559
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@codebytere @khalwa
fix: safer check for WCO button updates (electron#34833)
d2450fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@clavin clavin clavin approved these changes

@mlaurencin mlaurencin Awaiting requested review from mlaurencin

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@codebytere @miniak @zcbenz @clavin