New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: WCO pressed background state updates #34771
Conversation
4981b20
to
cfee973
Compare
53d5a90
to
6e94112
Compare
Looks like a valid test failure - i'm looking into it! |
6e94112
to
a9d4023
Compare
@clavin @mlaurencin tests fixed! |
Release Notes Persisted
|
I have automatically backported this PR to "17-x-y", please check out #34837 |
I have automatically backported this PR to "18-x-y", please check out #34838 |
I have automatically backported this PR to "19-x-y", please check out #34839 |
I have automatically backported this PR to "20-x-y", please check out #34840 |
Description of Change
Closes #34763.
When a window with WCO is restored after the minimize button is clicked, the button was left in the
STATE_HOVERED
state. This meant that when the user restored (unminimized) the window, the button was incorrectly left painted as though the user was still hovered over it, and could only fix this by once again hovering over the button and then moving off of it. This issue is fixed by ensuring that windows controls are reset when the window is restored, since the buttons could neither be pressed or hovered over as that is occurring by the nature of the event taking place.Tested by adding:
to the BrowserWindow ctor options of the default Fiddle.
Checklist
npm test
passesRelease Notes
Notes: Fixed an issue where the minimize button with WCO enabled would incorrectly be highlighted in some cases.