chore: backport a536de469 from node

[deepak1556]

Description of Change

Backports nodejs/node@a536de4

Fixes 32-bit native module builds with node-gyp@9.0.0 that uses config.gypi from bundled custom headers. Also removes redundant patch enable_31_bit_smis_on_64bit_arch_and_ptr_compression.patch since we always ship a single copy of config.gypi with pointer compression enabled since d1e0b63

Release Notes

Notes: Fix 32-bit native module builds with node-gyp >= 9.0.0

[deepak1556]

nan tests are failing because of older node-gyp toolchain being used which does not respect config.gypi generated by us.

gyp info using node-gyp@7.1.2
gyp info using node@14.17.5 | linux | x64

@MarshallOfSound I would like to remove enable_31_bit_smis_on_64bit_arch_and_ptr_compression.patch as follow-up on main and other branches as well, can we bump the node version for CI to use latest LTS node ? Another option, is we can bump the node-gyp version for the nan tests at

electron/.circleci/config/base.yml

Lines 1128 to 1129 in 3ba60de

	cd src
	node electron/script/nan-spec-runner.js

, which path is preferred ?

[jkleinsc]

@deepak1556 we should upgrade node in CI. This will require a new docker image. I started a PR here: electron/build-images#26

[deepak1556]

Great, thanks!

[deepak1556]

@jkleinsc 17-x-y is on an older image than main, 19-x-y and 18-x-y,

I don't think we can make a image update for this branch, so looks like updating node-gyp as part of the nan step would be better for this branch and 16-x-y ?

As for the newer branches, will they automatically get the node 16 image from electron/build-images#26 ? or does this require a tag update on electron/electron end similar to #27915 ?

[deepak1556]

Abandoned removing enable_31_bit_smis_on_64bit_arch_and_ptr_compression.patch for this branch, since it requires changes to CI images. PR now only backports the upstream change required to address 32-bit build failures.

[release-clerk]

Release Notes Persisted

Fix 32-bit native module builds with node-gyp >= 9.0.0

[trop]

I have automatically backported this PR to "16-x-y", please check out #34167

[jkleinsc]

@deepak1556 it would require updating the CircleCI config to pull in the right image by changing https://github.com/electron/electron/blob/main/.circleci/config/base.yml#L47