New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix nativeModulesEnabled in spec/webview-spec.js #34027
Conversation
19c686b
to
7b1d12f
Compare
7b1d12f
to
5dd27fc
Compare
No Release Notes |
I have automatically backported this PR to "15-x-y", please check out #34063 |
I have automatically backported this PR to "17-x-y", please check out #34064 |
I have automatically backported this PR to "16-x-y", please check out #34065 |
I have automatically backported this PR to "19-x-y", please check out #34066 |
I have automatically backported this PR to "18-x-y", please check out #34067 |
Description of Change
The logic was flipped
electron/spec/webview-spec.js
Line 10 in 7dee517
It needs to be
electron/spec-main/modules-spec.ts
Line 13 in 7dee517
electron/spec/static/main.js
Line 90 in 7dee517
Depends on #34026
Checklist
npm test
passesRelease Notes
Notes: none