Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick a1dc371d66 from chromium #33679

Merged
merged 1 commit into from Apr 14, 2022

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented Apr 8, 2022

usb: Fix OOB access with non-sequential interfaces

When accessing a usb device with non-sequential interface number or
alternative setting value, it might end up using index out of the
internal array allocated size. It is caused by using incorrect
parameters (i.e interface_number and alternate_setting) into the
callback which expects taking interface_index and alternate_index. Fix
it by passing the correct parameters which are already available in the
function to the callback.

Bug: 1286816
Change-Id: I6b3533f944f94e94e63959b99718858e089449da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3384715
Reviewed-by: Reilly Grant reillyg@chromium.org
Commit-Queue: Jack Hsieh chengweih@chromium.org
Cr-Commit-Position: refs/heads/main@{#961679}

Notes: Backported fix for chromium:1286816.

@ppontes ppontes added security 🔒 semver/patch backwards-compatible bug fixes backport-check-skip Skip trop's backport validity checking 15-x-y labels Apr 8, 2022
@ppontes ppontes requested review from a team as code owners April 8, 2022 15:52
@codebytere codebytere merged commit b60dfe4 into 15-x-y Apr 14, 2022
@codebytere codebytere deleted the cherry-pick/15-x-y/chromium/a1dc371d66 branch April 14, 2022 10:35
@release-clerk
Copy link

release-clerk bot commented Apr 14, 2022

Release Notes Persisted

Backported fix for chromium:1286816.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
15-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants