New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: crash when destroying node env with pending promises #33280
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a test - we should just need a very big file to load via fs.promises.read
4d92d7f
to
f4fa04a
Compare
Release Notes Persisted
|
I have automatically backported this PR to "15-x-y", please check out #33300 |
I have automatically backported this PR to "16-x-y", please check out #33301 |
I have automatically backported this PR to "18-x-y", please check out #33302 |
I have automatically backported this PR to "17-x-y", please check out #33303 |
/trop run backport |
The backport process for this PR has been manually initiated - here we go! :D |
I have automatically backported this PR to "17-x-y", please check out #33335 |
…3280) * fix: crash when destroying node env with pending promises * chore: add spec
…3280) * fix: crash when destroying node env with pending promises * chore: add spec
Description of Change
Fixes #33164
Checklist
npm test
passesRelease Notes
Notes: fix crash in the render process on reload with pending node fs.promises