New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fiddle ipc code pattern 3 #33262
Conversation
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
@erickzhao can you please review. |
Merging as CI failure unrelated to PR change. |
Congrats on merging your first pull request! 🎉🎉🎉 |
No Release Notes |
I was unable to backport this PR to "18-x-y" cleanly; |
I have automatically backported this PR to "17-x-y", please check out #33295 |
I still want to know why CI fails what steps I missed to avoid this in future Thanks |
Description of Change
Closes #32867
Fixed docs and fiddle code and tested with the fiddle.
ipcMain
in docs code.event.reply
toevent.sender.send
as reply is not a function anymore in process event.Checklist
npm test
passesRelease Notes
Notes: none