Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fiddle ipc code pattern 3 #33262

Merged
merged 1 commit into from Mar 16, 2022
Merged

Conversation

akgupta0777
Copy link
Contributor

@akgupta0777 akgupta0777 commented Mar 13, 2022

Description of Change

Closes #32867

Fixed docs and fiddle code and tested with the fiddle.

  • Added missing requirement ipcMain in docs code.
  • Modified event.reply to event.sender.send as reply is not a function anymore in process event.

Checklist

  • npm test passes
  • relevant documentation is changed or added

Release Notes

Notes: none

@welcome
Copy link

welcome bot commented Mar 13, 2022

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 13, 2022
@akgupta0777
Copy link
Contributor Author

@erickzhao can you please review.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 15, 2022
@codebytere codebytere added semver/patch backwards-compatible bug fixes target/17-x-y and removed semver/none labels Mar 16, 2022
@jkleinsc
Copy link
Contributor

Merging as CI failure unrelated to PR change.

@jkleinsc jkleinsc merged commit b274011 into electron:main Mar 16, 2022
1 check passed
@welcome
Copy link

welcome bot commented Mar 16, 2022

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Mar 16, 2022

No Release Notes

@trop
Copy link
Contributor

trop bot commented Mar 16, 2022

I was unable to backport this PR to "18-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Mar 16, 2022

I have automatically backported this PR to "17-x-y", please check out #33295

@akgupta0777
Copy link
Contributor Author

Merging as CI failure unrelated to PR change.

I still want to know why CI fails what steps I missed to avoid this in future

Thanks

khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📓 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Fiddle in Inter-Process Communication Documentation not working and code missing an import
5 participants