Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick f5101995acd2 from chromium #32638

Merged
merged 2 commits into from
Jan 28, 2022

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Jan 26, 2022

fix draggable regions not updating without layout

This fixes draggable regions not being updated when styles change, but there is
no layout as a result of the style change. Some changes to styles can cause a
change in draggable regions without causing a layout (e.g. applying the
-webkit-app-region: drag style to an element without changing its size).

Bug: 1051562
Change-Id: Ifdf835be9e6c762131529b4309c6579366b80d6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3416279
Reviewed-by: Stefan Zager szager@chromium.org
Commit-Queue: Jeremy Apthorp jeremya@chromium.org
Cr-Commit-Position: refs/heads/main@{#963777}

Notes: Fixed draggable regions not updating unless a relayout occurs.

@nornagon nornagon requested a review from a team as a code owner January 26, 2022 23:58
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 26, 2022
@nornagon nornagon added 17-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes labels Jan 26, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 26, 2022
@nornagon
Copy link
Member Author

Ref #32341

@nornagon nornagon merged commit 3f521ca into 17-x-y Jan 28, 2022
@nornagon nornagon deleted the cherry-pick/17-x-y/chromium/f5101995acd2 branch January 28, 2022 00:54
@release-clerk
Copy link

release-clerk bot commented Jan 28, 2022

Release Notes Persisted

Fixed draggable regions not updating unless a relayout occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
17-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants