fix: strip crashpad_handler binary #32548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
2 tasks
trop
bot
added
15-x-y
backport
miniak
approved these changes
Jan 20, 2022
deermichel
approved these changes
Jan 21, 2022
|
This currently fails to build on linux like this: Traceback (most recent call last):
File "/home/builduser/project/depot_tools/ninjalog_uploader_wrapper.py", line 126, in <module>
sys.exit(main())
File "/home/builduser/project/depot_tools/ninjalog_uploader_wrapper.py", line 79, in main
config = LoadConfig()
File "/home/builduser/project/depot_tools/ninjalog_uploader_wrapper.py", line 32, in LoadConfig
'is-googler': ninjalog_uploader.IsGoogler(),
File "/home/builduser/project/depot_tools/ninjalog_uploader.py", line 45, in IsGoogler
shell=True)
File "/usr/lib/python3.6/subprocess.py", line 423, in run
with Popen(*popenargs, **kwargs) as process:
TypeError: __init__() got an unexpected keyword argument 'capture_output'Landing #32573 first should fix it. |
zcbenz
approved these changes
Jan 24, 2022
|
Release Notes Persisted
|
zcbenz
deleted the
trop/15-x-y-bp-fix-strip-crashpad_handler-binary-1642650574501
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #32540
See that PR for details.
Notes: Strip symbols from crashpad_handler binary on Linux, reducing bundle size.