Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: will-attach-webview handler modifying params.instanceId does not break <webview> #32430

Merged
merged 1 commit into from
Jan 13, 2022
Merged

fix: will-attach-webview handler modifying params.instanceId does not break <webview> #32430

merged 1 commit into from
Jan 13, 2022

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jan 12, 2022

Backport of #32386

See that PR for details.

Notes: The <webview> implementation was made more robust, it no longer breaks when will-attach-webview handler modifies the internal params.instanceId.

@trop trop bot requested a review from a team as a code owner January 12, 2022 07:42
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 12, 2022
@trop trop bot requested a review from miniak January 12, 2022 07:42
@trop trop bot mentioned this pull request Jan 12, 2022
Merged
4 tasks
@trop trop bot added 17-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jan 12, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 12, 2022
@zcbenz zcbenz merged commit e87666e into 17-x-y Jan 13, 2022
@zcbenz zcbenz deleted the trop/17-x-y-bp-fix-will-attach-webview-handler-modifying-params-instanceid-does-not-break-webview--1641973316837 branch January 13, 2022 00:40
@release-clerk
Copy link

release-clerk bot commented Jan 13, 2022

Release Notes Persisted

The &lt;webview&gt; implementation was made more robust, it no longer breaks when will-attach-webview handler modifies the internal params.instanceId.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

@miniak miniak Awaiting requested review from miniak

Assignees
No one assigned
Labels
17-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zcbenz @codebytere @miniak