Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect skipTransformProcessType option parsing in win.setVisibleOnAllWorkspaces() #32364

Merged
merged 1 commit into from Jan 10, 2022
Merged

fix: incorrect skipTransformProcessType option parsing in win.setVisibleOnAllWorkspaces() #32364

merged 1 commit into from Jan 10, 2022

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jan 6, 2022

Description of Change

Fix incorrect skipTransformProcessType option parsing added in #27200.

Checklist

Release Notes

Notes: Fixed incorrect skipTransformProcessType option parsing in win.setVisibleOnAllWorkspaces().

@miniak miniak added semver/patch backwards-compatible bug fixes target/13-x-y labels Jan 6, 2022
@miniak miniak self-assigned this Jan 6, 2022
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 6, 2022
@miniak miniak force-pushed the miniak/fix-skip-transform-process-type branch from c12cb4c to d77fdc8 Compare January 6, 2022 02:28
@miniak miniak requested a review from codebytere January 6, 2022 02:29
@miniak
Copy link
Contributor Author

miniak commented Jan 6, 2022

cc @CyrusRoshan

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 7, 2022
@codebytere codebytere merged commit cb2c1f8 into main Jan 10, 2022
@codebytere codebytere deleted the miniak/fix-skip-transform-process-type branch January 10, 2022 10:00
@release-clerk
Copy link

release-clerk bot commented Jan 10, 2022

Release Notes Persisted

Fixed incorrect skipTransformProcessType option parsing in win.setVisibleOnAllWorkspaces().

@trop trop bot mentioned this pull request Jan 10, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Jan 10, 2022

I have automatically backported this PR to "13-x-y", please check out #32394

@trop trop bot mentioned this pull request Jan 10, 2022
Merged
@trop trop bot removed the target/13-x-y label Jan 10, 2022
This was referenced Jan 10, 2022
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Jan 10, 2022

I have automatically backported this PR to "14-x-y", please check out #32395

@trop
Copy link
Contributor

trop bot commented Jan 10, 2022

I have automatically backported this PR to "15-x-y", please check out #32396

@trop
Copy link
Contributor

trop bot commented Jan 10, 2022

I have automatically backported this PR to "16-x-y", please check out #32397

@trop
Copy link
Contributor

trop bot commented Jan 10, 2022

I have automatically backported this PR to "17-x-y", please check out #32398

t57ser pushed a commit to t57ser/electron that referenced this pull request Jan 25, 2022
@miniak @t57ser
fix: incorrect skipTransformProcessType option parsing in `win.setV…
cda97ef 
…isibleOnAllWorkspaces()` (electron#32364)
@commit-lint commit-lint bot mentioned this pull request Mar 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees

@miniak miniak

Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@miniak @codebytere