Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash caused by app.getLocaleCountryCode() #32322

Commits on Jan 3, 2022

  1. fix: crash caused by app.getLocaleCountryCode()

    CFLocaleGetValue() returned null and crashed the process when
    app.getLocaleCountryCode() was run on a CircleCI metal resource class
    macOS instance with Xcode 12.5.1. This change fixes that logic and adds
    further checks to make the code future-proof.
    
    Here too people are complaining that the returned country code migth be
    null: https://stackoverflow.com/questions/15202454/nslocalecountrycode-returns-nil
    
    Signed-off-by: Darshan Sen <darshan.sen@postman.com>
    RaisinTen authored and electron-bot committed Jan 3, 2022
    Copy the full SHA
    278f3ef View commit details
    Browse the repository at this point in the history