fix: older systems crash when playing media files #32046
Conversation
patches/chromium/fix_media_key_usage_with_globalshortcuts.patch
Outdated
Show resolved
Hide resolved
| + system_media_controls_.get()); | ||
| + | ||
| } | ||
|
|
||
| + // Directly listen for media key keypresses when using GlobalShortcuts. | ||
| + media_keys_listener_ = ui::MediaKeysListener::Create( | ||
| + this, ui::MediaKeysListener::Scope::kGlobal); | ||
| + DCHECK(media_keys_listener_); |
There was a problem hiding this comment.
I think you've broken line endings here or something? This line is marked as changed when nothing has changed, can you clean up this diff so that only changed lines are committed?
There was a problem hiding this comment.
So I tried a couple of things now, this is the cleanest version I get with e patches chromium. Some lines get shuffled because with the if-clause, git interprets changes a little bit different.
There was a problem hiding this comment.
If I try to remove the + or line end at end of the file, I end up with a corrupt patch.
deermichel
force-pushed
the
deermichel/media-patch
branch
from
000e610
to
7039be6
Compare
deermichel
force-pushed
the
deermichel/media-patch
branch
from
7039be6
to
abb27d1
Compare
deermichel
changed the title
|
We'd really love to help this move forward. Please let me know if I can help with getting this merged in any way! Thanks for the fix! ❤️ |
|
This PR requires review from @electron/wg-upgrades. But just a notice that this organization won't have much activity this month, so even if it is merged we might have to wait until next month before it is released. |
|
any news? |
|
lately we encountered crashes when playing video files, looking forward for this ! |
|
Is there any workround to avoid crash when play media files before this PR getting merged ? |
|
@bruceauyeung downgrading to 15.3.0 / 14.2.0 / 13.6.0 works |
|
I have automatically backported this PR to "16-x-y", please check out #32215 |
|
13.x seems to be still updating, |
|
@deermichel has manually backported this PR to "13-x-y", please check out #32348 |
|
@deermichel has manually backported this PR to "14-x-y", please check out #32349 |
* fix: win7 crash when playing media * reset * chore: update patches Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Description of Change
Closes #31762.
Regression caused by #31492. On Windows 7 & 8 / macOS 10.11/10.12,
system_media_controls_isnullptrand calling methods on it crashes the process. This PR wraps problematic statements in an if-clause like upstream Chromium does.I manually checked that MediaMetadata still works on Windows 10 and above.
cc @codebytere @lyswhut @miniak
Checklist
npm testpasses / manually validatedRelease Notes
Notes: Fixed crash when playing media files on Windows 7/8 or macOS 10.11/10.12.