New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add playwright e2e testing docs #31961
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! Very detailed and easy to follow - thanks so much for putting this together! 🙇♀️
Had one small question about formatting, but not merge-blocking
npm install --save-dev @playwright/test | ||
``` | ||
|
||
:::caution Dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit: The callout formats here (:::caution
, :::info
, etc) don't seem to work with GitHub's rich text format. This might be fine and show up properly in the docs themselves, just wanted to call it out just in case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, this is admonition syntax baked into Docusaurus 2: https://docusaurus.io/docs/next/markdown-features/admonitions
When creating new tutorials, I've been using the website repo to create deploy previews to show how they look on the live website: https://electronjsorg-new-pr-152.herokuapp.com/docs/latest/tutorial/automated-testing/#using-playwright
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh awesome, sorry, just saw you included that in the PR description and I missed it 🙂 Looks great!
No Release Notes |
I have automatically backported this PR to "16-x-y", please check out #31974 |
I have automatically backported this PR to "17-x-y", please check out #31975 |
Description of Change
Adds documentation on Playwright's experimental Electron support as part of our Spectron deprecation initiative.
See https://electronjsorg-new-pr-152.herokuapp.com/docs/latest/tutorial/automated-testing/#using-playwright for website preview
cc @VerteDinde
Checklist
npm test
passesRelease Notes
Notes: none