Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add playwright e2e testing docs #31961

Merged
merged 1 commit into from Nov 23, 2021

Conversation

erickzhao
Copy link
Member

Description of Change

Adds documentation on Playwright's experimental Electron support as part of our Spectron deprecation initiative.

See https://electronjsorg-new-pr-152.herokuapp.com/docs/latest/tutorial/automated-testing/#using-playwright for website preview

cc @VerteDinde

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 23, 2021
@erickzhao erickzhao requested review from a team and VerteDinde November 23, 2021 00:29
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Very detailed and easy to follow - thanks so much for putting this together! 🙇‍♀️

Had one small question about formatting, but not merge-blocking

npm install --save-dev @playwright/test
```

:::caution Dependencies
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit: The callout formats here (:::caution, :::info, etc) don't seem to work with GitHub's rich text format. This might be fine and show up properly in the docs themselves, just wanted to call it out just in case.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this is admonition syntax baked into Docusaurus 2: https://docusaurus.io/docs/next/markdown-features/admonitions

When creating new tutorials, I've been using the website repo to create deploy previews to show how they look on the live website: https://electronjsorg-new-pr-152.herokuapp.com/docs/latest/tutorial/automated-testing/#using-playwright

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh awesome, sorry, just saw you included that in the PR description and I missed it 🙂 Looks great!

@release-clerk
Copy link

release-clerk bot commented Nov 23, 2021

No Release Notes

@trop
Copy link
Contributor

trop bot commented Nov 23, 2021

I have automatically backported this PR to "16-x-y", please check out #31974

@trop
Copy link
Contributor

trop bot commented Nov 23, 2021

I have automatically backported this PR to "17-x-y", please check out #31975

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 24, 2021
t57ser pushed a commit to t57ser/electron that referenced this pull request Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants