fix: media shouldn't open permissions dialog #31837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
Playing media shouldn't open Accessibility permissions dialog on macOS. However, we still need to watch for media events, just not globally and `media_keys_listener_` is an API over global capture of the media keys. The fix is to let chromium call `UpdateWhichKeysAreListenedFor` which will call `UpdateSystemMediaControlsEnabledControls` and watch for events on `system_media_controls_` without triggering permissions popup.
5 tasks
trop
bot
added
16-x-y
backport
codebytere
approved these changes
Nov 15, 2021
VerteDinde
approved these changes
Nov 15, 2021
VerteDinde
deleted the
trop/16-x-y-bp-fix-media-shouldn-t-open-permissions-dialog-1636982194040
branch
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #31805
See that PR for details.
Notes: Fixed an issue where playing media would open Accessibility permissions dialog on macOS.