Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect Content-Disposition serialization #31669

Merged
merged 2 commits into from Nov 3, 2021

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Nov 2, 2021

Description of Change

Closes #31662.
Refs #25961.

Fixes an issue where Content-Disposition filenames would be incorrectly truncated at the first comma for filename attachments which contained one. This was happening becuase the filename in the parse net::HttpContentDisposition header was not being correctly wrapped in double quotes, thereby breaking serialization.

Tested with the repro provided in the above linked issue:

Before Screen Shot 2021-11-02 at 2 35 19 PM
After Screen Shot 2021-11-02 at 2 31 23 PM

Checklist

Release Notes

Notes: Fixes an issue where Content-Disposition filenames would be incorrectly truncated at the first comma for a filename attachment which contained one.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/13-x-y labels Nov 2, 2021
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 2, 2021
@deepak1556
Copy link
Member

Can you also update the test added in #25961 to also reflect this change ? Thanks!

@codebytere
Copy link
Member Author

@deepak1556 done, thanks!

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 3, 2021
@jkleinsc jkleinsc merged commit 24b02d6 into main Nov 3, 2021
@jkleinsc jkleinsc deleted the fix-incorrect-serialization branch November 3, 2021 14:11
@release-clerk
Copy link

release-clerk bot commented Nov 3, 2021

Release Notes Persisted

Fixes an issue where Content-Disposition filenames would be incorrectly truncated at the first comma for a filename attachment which contained one.

@trop
Copy link
Contributor

trop bot commented Nov 3, 2021

I have automatically backported this PR to "13-x-y", please check out #31691

@trop
Copy link
Contributor

trop bot commented Nov 3, 2021

I have automatically backported this PR to "14-x-y", please check out #31692

@trop
Copy link
Contributor

trop bot commented Nov 3, 2021

I have automatically backported this PR to "15-x-y", please check out #31693

@trop
Copy link
Contributor

trop bot commented Nov 3, 2021

I have automatically backported this PR to "16-x-y", please check out #31694

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Download filename will be cut up to the first comma
4 participants