Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use disable-hid-blocklist to allow FIDO devices #31626

Merged
merged 1 commit into from
Nov 1, 2021
Merged

fix: use disable-hid-blocklist to allow FIDO devices #31626

merged 1 commit into from
Nov 1, 2021

Conversation

jkleinsc
Copy link
Contributor

@jkleinsc jkleinsc commented Oct 28, 2021 •
edited by codebytere

Description of Change

This PR changes WebHID to use the disable-hid-blocklist flag to enable access to FIDO devices. The original WebHID implementation disallowed access to all FIDO devices for security reasons, but using the disable-hid-blocklist flag (which is by default false) allow developers to opt-in to FIDO device access while maintaining the default of disabling access to FIDO devices via WebHID.

Closes #31595

Checklist

Release Notes

Notes: changed WebHID to use disable-hid-blocklist flag to enable FIDO devices.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 28, 2021
@jkleinsc jkleinsc added semver/patch backwards-compatible bug fixes target/15-x-y labels Oct 28, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 29, 2021
@jkleinsc jkleinsc merged commit a938af3 into main Nov 1, 2021
@jkleinsc jkleinsc deleted the allow-hid-fido-disable-blocklist branch November 1, 2021 14:00
@release-clerk
Copy link

release-clerk bot commented Nov 1, 2021

Release Notes Persisted

changed WebHID to use disable-hid-blocklist flag to enable FIDO devices.

This was referenced Nov 1, 2021
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Nov 1, 2021

I have automatically backported this PR to "15-x-y", please check out #31649

@trop
Copy link
Contributor

trop bot commented Nov 1, 2021

I have automatically backported this PR to "16-x-y", please check out #31650

t57ser pushed a commit to t57ser/electron that referenced this pull request Jan 25, 2022
@jkleinsc @t57ser
fix: use disable-hid-blocklist to allow FIDO (electron#31626)
013a385
@commit-lint commit-lint bot mentioned this pull request Feb 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: ElectronHidDelegate::IsFidoAllowedForOrigin ignores kDisableHidBlocklist switch
2 participants
@jkleinsc @codebytere