Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update chore_add_context_to_context_aware_module_prevention.patch #31579

Merged
merged 1 commit into from Oct 26, 2021

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Oct 25, 2021

Description of Change

Change

"Loading non-context-aware native module in renderer: '%s', but app.allowRendererProcessReuse is true. See https://github.com/electron/electron/issues/18397."

to

"Loading non-context-aware native module in renderer: '%s'. See https://github.com/electron/electron/issues/18397."

as app.allowRendererProcessReuse does not exist anymore. Follow-up to #26874

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes

Release Notes

Notes: none

@miniak miniak added semver/patch backwards-compatible bug fixes target/14-x-y labels Oct 25, 2021
@miniak miniak self-assigned this Oct 25, 2021
@miniak miniak requested a review from a team as a code owner October 25, 2021 17:14
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 25, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 26, 2021
@jkleinsc jkleinsc merged commit be8b1a2 into main Oct 26, 2021
@jkleinsc jkleinsc deleted the miniak/node-context-aware-module-patch branch October 26, 2021 19:50
@release-clerk
Copy link

release-clerk bot commented Oct 26, 2021

No Release Notes

@trop
Copy link
Contributor

trop bot commented Oct 26, 2021

I was unable to backport this PR to "14-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/14-x-y label Oct 26, 2021
@trop
Copy link
Contributor

trop bot commented Oct 26, 2021

I was unable to backport this PR to "15-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Oct 26, 2021

I was unable to backport this PR to "16-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Oct 28, 2021

@miniak has manually backported this PR to "14-x-y", please check out #31627

@trop
Copy link
Contributor

trop bot commented Oct 28, 2021

@miniak has manually backported this PR to "15-x-y", please check out #31628

@trop
Copy link
Contributor

trop bot commented Oct 28, 2021

@miniak has manually backported this PR to "16-x-y", please check out #31629

t57ser pushed a commit to t57ser/electron that referenced this pull request Oct 29, 2021
t57ser pushed a commit to t57ser/electron that referenced this pull request Oct 29, 2021
t57ser pushed a commit to t57ser/electron that referenced this pull request Oct 29, 2021
t57ser pushed a commit to t57ser/electron that referenced this pull request Oct 29, 2021
jkleinsc pushed a commit that referenced this pull request Nov 1, 2021
…tch (#31579) (#31628)

Co-authored-by: Milan Burda <miburda@microsoft.com>
jkleinsc pushed a commit that referenced this pull request Nov 1, 2021
…tch (#31579) (#31627)

Co-authored-by: Milan Burda <miburda@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants