fix: navigator.keyboard.lock() not working #31572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Should be rebased when #31573 is merged. |
codebytere
force-pushed
the
keyboard-lock
branch
from
cc963ef
to
c57cf23
Compare
codebytere
force-pushed
the
keyboard-lock
branch
from
6b10342
to
abd9717
Compare
jkleinsc
reviewed
Oct 26, 2021
patches/chromium/fix_patch_out_permissions_checks_in_exclusive_access.patch
Outdated
Show resolved
Hide resolved
zcbenz
reviewed
Oct 27, 2021
codebytere
force-pushed
the
keyboard-lock
branch
from
abd9717
to
ac16eef
Compare
codebytere
force-pushed
the
keyboard-lock
branch
from
ac16eef
to
9f89d00
Compare
zcbenz
approved these changes
Oct 28, 2021
jkleinsc
approved these changes
Oct 28, 2021
|
Release Notes Persisted
|
|
I was unable to backport this PR to "15-x-y" cleanly; |
|
I have automatically backported this PR to "16-x-y", please check out #31621 |
|
@codebytere has manually backported this PR to "15-x-y", please check out #31846 |
nornagon
reviewed
Jan 5, 2022
| @@ -1346,6 +1389,18 @@ void WebContents::FindReply(content::WebContents* web_contents, | |||
| Emit("found-in-page", result.GetHandle()); | |||
| } | |||
|
|
|||
| void WebContents::RequestKeyboardLock(content::WebContents* web_contents, | |||
| bool esc_key_locked) { | |||
| exclusive_access_manager_->keyboard_lock_controller()->RequestKeyboardLock( | |||
There was a problem hiding this comment.
We should allow the browser process to deny this; does this go through existing permissions stuff or do we need to add something new?
3 tasks
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Jan 25, 2022
* fix: navigator.keyboard.lock() not working * chore: address review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #31420.
Fixes an issue where
navigator.keyboard.lock()did not work. The patch surface here is fairly small, and might be best combined with another similar patch. I considered potentially subclassing, but the maintenance burden there I felt to be greater since that would require subclassing and pulling in huge swathes ofchrome/browser/ui/exclusive_access.Please leave general thoughts or if you have them, alternative approaches to minimize change surface!
Checklist
npm testpassesRelease Notes
Notes: Enables support for
navigator.keyboard.lock().