-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add data parameter to app.requestSingleInstanceLock()
#31444
Merged
zcbenz
merged 15 commits into
16-x-y
from
trop/16-x-y-bp-feat-add-data-parameter-to-app-requestsingleinstancelock--1634261564633
Oct 21, 2021
Merged
feat: Add data parameter to app.requestSingleInstanceLock()
#31444
zcbenz
merged 15 commits into
16-x-y
from
trop/16-x-y-bp-feat-add-data-parameter-to-app-requestsingleinstancelock--1634261564633
Oct 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
trop
bot
added
16-x-y
backport
This is a backport PR
backport/requested 🗳
semver/minor
backwards-compatible functionality
labels
Oct 15, 2021
jkleinsc
approved these changes
Oct 19, 2021
VerteDinde
approved these changes
Oct 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved on behalf of @electron/wg-releases
In the Oct 20 meeting, @electron/wg-releases agreed for this in 16 but not to 15 due to patch size. |
…app-requestsingleinstancelock--1634261564633
zcbenz
approved these changes
Oct 21, 2021
zcbenz
deleted the
trop/16-x-y-bp-feat-add-data-parameter-to-app-requestsingleinstancelock--1634261564633
branch
October 21, 2021 12:52
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
16-x-y
backport/approved ✅
backport
This is a backport PR
semver/minor
backwards-compatible functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #30891
See that PR for details.
Notes: add new data parameter to
app.requestSingleInstanceLock()