Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add data parameter to app.requestSingleInstanceLock() #31444

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Oct 15, 2021

Backport of #30891

See that PR for details.

Notes: add new data parameter to app.requestSingleInstanceLock()

@trop trop bot requested a review from a team as a code owner October 15, 2021 01:32
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 15, 2021
@trop trop bot added 16-x-y backport This is a backport PR backport/requested 🗳 semver/minor backwards-compatible functionality labels Oct 15, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 15, 2021
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of @electron/wg-releases

@ckerr
Copy link
Member

ckerr commented Oct 20, 2021

In the Oct 20 meeting, @electron/wg-releases agreed for this in 16 but not to 15 due to patch size.

…app-requestsingleinstancelock--1634261564633
@zcbenz zcbenz merged commit d3ff203 into 16-x-y Oct 21, 2021
@zcbenz zcbenz deleted the trop/16-x-y-bp-feat-add-data-parameter-to-app-requestsingleinstancelock--1634261564633 branch October 21, 2021 12:52
@release-clerk
Copy link

release-clerk bot commented Oct 21, 2021

Release Notes Persisted

add new data parameter to app.requestSingleInstanceLock()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
16-x-y backport/approved ✅ backport This is a backport PR semver/minor backwards-compatible functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants