-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: also pass securityOrigin to media permissions request handler #31357
Conversation
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API looks good to me.
I'm changing this from |
API LGTM |
I think we do want to potentially backport this cc @zcbenz |
My bad on the Just wanted to check in on if there was anything anyone was waiting for me for on this PR: is there anything I should be doing on this right now? |
Merging as CI failures are known flake unrelated to this PR. |
Congrats on merging your first pull request! 🎉🎉🎉 |
Release Notes Persisted
|
I have automatically backported this PR to "15-x-y", please check out #31417 |
/trop run backport-to 14-x-y |
The backport process for this PR has been manually initiated - sending your PR to |
/trop run backport-to 13-x-y |
The backport process for this PR has been manually initiated - sending your PR to |
I have automatically backported this PR to "14-x-y", please check out #31436 |
I have automatically backported this PR to "13-x-y", please check out #31437 |
For
media
requests, the handler passed tosetPermissionRequestHandler
seems to always get a reference to the top-level frame and the top-level URL, and is not passed the request'ssecurity_origin
. For consistency withsetPermissionCheckHandler
's handling of this case formedia
requests, pass the request'ssecurity_origin
as a newsecurityOrigin
field in details to enable disambiguation.Checklist
npm test
passes -> ran undere test --runners=main
, everything seemed to behave just as it did before the changeRelease Notes
Notes: Began passing securityOrigin in details for permission request handlers for media requests in addition to permission check handlers.