feat: warn when ipcRenderer.sendSync() called with no listeners for channel #31344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
force-pushed
the
miniak/ipc-send-sync-no-listeners
branch
from
beec9eb
to
500a125
Compare
miniak
force-pushed
the
miniak/ipc-send-sync-no-listeners
branch
from
500a125
to
8eeb8f4
Compare
zcbenz
approved these changes
Oct 11, 2021
jkleinsc
approved these changes
Oct 14, 2021
|
Merging as CI failure is flake unrelated to PR change. |
|
Release Notes Persisted
|
This was referenced Oct 14, 2021
|
I have automatically backported this PR to "13-x-y", please check out #31432 |
|
I have automatically backported this PR to "14-x-y", please check out #31433 |
|
I have automatically backported this PR to "15-x-y", please check out #31434 |
|
I have automatically backported this PR to "16-x-y", please check out #31435 |
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 27, 2021
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 27, 2021
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 29, 2021
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 29, 2021
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 29, 2021
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Inspired by #31321
Checklist
npm testpassesRelease Notes
Notes: Added warning when
ipcRenderer.sendSync()is called with no listeners for channel onipcMain.