Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return HTNOWHERE in resize hit test to allow draggable regions to kick in when required #31300

Merged
merged 1 commit into from Oct 6, 2021
Merged

fix: return HTNOWHERE in resize hit test to allow draggable regions to kick in when required #31300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions shell/browser/ui/views/frameless_view.cc
View file
Open in desktop
Expand Up @@ -40,10 +40,10 @@ int FramelessView::ResizingBorderHitTest(const gfx::Point& point) {
: false;

// https://github.com/electron/electron/issues/611
// If window isn't resizable, we should always return HTCLIENT, otherwise the
// If window isn't resizable, we should always return HTNOWHERE, otherwise the
// hover state of DOM will not be cleared probably.
if (!can_ever_resize)
return HTCLIENT;
return HTNOWHERE;

// Don't allow overlapping resize handles when the window is maximized or
// fullscreen, as it can't be resized in those states.
Expand Down