Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing 'context-menu' event to webview-tag.md #31277

Merged
merged 1 commit into from Oct 6, 2021

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Oct 4, 2021

Description of Change

The 'context-menu' event is forwarded to the <webview>, but it's not documented there.

'context-menu': ['params'],

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • relevant documentation is changed or added

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 4, 2021
@miniak miniak self-assigned this Oct 4, 2021
@miniak miniak added semver/patch backwards-compatible bug fixes target/13-x-y labels Oct 4, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 5, 2021
@deepak1556 deepak1556 merged commit 36ed216 into main Oct 6, 2021
@deepak1556 deepak1556 deleted the miniak/webview-context-menu-docs branch October 6, 2021 03:42
@release-clerk
Copy link

release-clerk bot commented Oct 6, 2021

No Release Notes

@trop
Copy link
Contributor

trop bot commented Oct 6, 2021

I have automatically backported this PR to "13-x-y", please check out #31308

@trop trop bot added the in-flight/13-x-y label Oct 6, 2021
@trop
Copy link
Contributor

trop bot commented Oct 6, 2021

I have automatically backported this PR to "15-x-y", please check out #31309

@trop trop bot removed the target/13-x-y label Oct 6, 2021
@trop
Copy link
Contributor

trop bot commented Oct 6, 2021

I have automatically backported this PR to "14-x-y", please check out #31310

@trop trop bot added the in-flight/15-x-y label Oct 6, 2021
@trop
Copy link
Contributor

trop bot commented Oct 6, 2021

I have automatically backported this PR to "16-x-y", please check out #31311

@trop trop bot added merged/15-x-y and removed target/16-x-y labels Oct 6, 2021
t57ser pushed a commit to t57ser/electron that referenced this pull request Oct 27, 2021
t57ser pushed a commit to t57ser/electron that referenced this pull request Oct 27, 2021
t57ser pushed a commit to t57ser/electron that referenced this pull request Oct 29, 2021
t57ser pushed a commit to t57ser/electron that referenced this pull request Oct 29, 2021
t57ser pushed a commit to t57ser/electron that referenced this pull request Oct 29, 2021
t57ser pushed a commit to t57ser/electron that referenced this pull request Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📓 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants