Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Enable X509_V_FLAG_TRUSTED_FIRST flag in BoringSSL #31216

Merged
merged 2 commits into from Sep 30, 2021
Merged

fix: Enable X509_V_FLAG_TRUSTED_FIRST flag in BoringSSL #31216

merged 2 commits into from Sep 30, 2021

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Sep 30, 2021

Backport of #31213

See that PR for details.

Notes: Fix Let's Encrypt DST Root CA X3 certificate expiration.

@jviotti @electron-bot
fix: Enable X509_V_FLAG_TRUSTED_FIRST flag in BoringSSL
70a0ac2 
Fixes: #31212
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@trop trop bot requested a review from a team as a code owner September 30, 2021 20:23
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 30, 2021
@trop trop bot mentioned this pull request Sep 30, 2021
Merged
4 tasks
@trop trop bot added 14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Sep 30, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 30, 2021
MarshallOfSound
MarshallOfSound approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 bad merge fixed

@VerteDinde VerteDinde added the fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases label Sep 30, 2021
VerteDinde
VerteDinde requested changes Sep 30, 2021
View reviewed changes
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold for linux-x64-testing

@VerteDinde VerteDinde merged commit 0742df7 into 14-x-y Sep 30, 2021
@VerteDinde VerteDinde deleted the trop/14-x-y-bp-fix-enable-x509_v_flag_trusted_first-flag-in-boringssl-1633033394204 branch September 30, 2021 21:00
@release-clerk
Copy link

release-clerk bot commented Sep 30, 2021

Release Notes Persisted

Fix Let's Encrypt DST Root CA X3 certificate expiration.

deepak1556 added a commit that referenced this pull request Sep 30, 2021
@deepak1556
Revert "fix: Enable X509_V_FLAG_TRUSTED_FIRST flag in BoringSSL (#31216…
d588738 
…)"

This reverts commit 0742df7.
@mqtik mqtik mentioned this pull request Oct 1, 2021
Closed
@NotWearingPants NotWearingPants mentioned this pull request Oct 3, 2021
Closed
zcbenz pushed a commit that referenced this pull request Oct 4, 2021
@deepak1556
fix: remove expired DST Root CA X3 (#31221)
78c2f49 
* Revert "fix: Enable X509_V_FLAG_TRUSTED_FIRST flag in BoringSSL (#31216)"

This reverts commit 0742df7.

* fix: remove expired DST Root CA X3
@wartab wartab mentioned this pull request Oct 8, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VerteDinde VerteDinde VerteDinde approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
14-x-y backport This is a backport PR fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@VerteDinde @MarshallOfSound @jviotti