Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BrowserView drag now delegates to the OS when possible #31114

Merged
merged 1 commit into from Sep 28, 2021

Conversation

anulman
Copy link
Contributor

@anulman anulman commented Sep 24, 2021

Description of Change

This PR fixes issue #31058, inconsistent window dragging behavior between BrowserWindows and BrowserViews. The root cause was a malformed selector, which no view.window instances could respond to.

https://www.loom.com/share/3ab47d45a0be4223af88b3377a800cd9

[Guidance appreciated for the Checklist and Release Notes sections. This change should help Electron better implement its current documentation; no new docs or userland education is expected. npm test is failing for me on node-gyp rebuilds, so hoping CI can confirm this is safe.]

Checklist

Release Notes

Notes: Fixes an issue where BrowserView dragging behavior was inconsistent with MacOS window dragging.

@welcome
Copy link

welcome bot commented Sep 24, 2021

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 24, 2021
@anulman anulman changed the title Fix: BrowserView drag now delegates to the OS when possible fix: BrowserView drag now delegates to the OS when possible Sep 24, 2021
@anulman
Copy link
Contributor Author

anulman commented Sep 24, 2021

cc @codebytere ; here is the PR for #31058

@codebytere codebytere self-requested a review September 28, 2021 15:42
@codebytere codebytere added target/13-x-y semver/patch backwards-compatible bug fixes labels Sep 28, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 28, 2021
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey great find!

@anulman
Copy link
Contributor Author

anulman commented Sep 28, 2021

Thank you! 😄

Anything else you need from me? I see all checks have passed but I'm not authorized to merge:

image

@codebytere codebytere merged commit abf6f1c into electron:main Sep 28, 2021
@welcome
Copy link

welcome bot commented Sep 28, 2021

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Sep 28, 2021

Release Notes Persisted

Fixes an issue where BrowserView dragging behavior was inconsistent with MacOS window dragging.

@trop
Copy link
Contributor

trop bot commented Sep 28, 2021

I have automatically backported this PR to "13-x-y", please check out #31175

@trop
Copy link
Contributor

trop bot commented Sep 28, 2021

I have automatically backported this PR to "14-x-y", please check out #31176

@trop trop bot removed the target/13-x-y label Sep 28, 2021
@trop
Copy link
Contributor

trop bot commented Sep 28, 2021

I have automatically backported this PR to "15-x-y", please check out #31177

@trop
Copy link
Contributor

trop bot commented Sep 28, 2021

I have automatically backported this PR to "16-x-y", please check out #31178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants