Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add textWidth option to dialog.showMessageBox() #31088

Merged
merged 1 commit into from Sep 29, 2021
Merged

feat: add textWidth option to dialog.showMessageBox() #31088

merged 1 commit into from Sep 29, 2021

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Sep 23, 2021

Backport of #30474

See that PR for details.

Notes: Added textWidth option to dialog.showMessageBox() / dialog.showMessageBoxSync().

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 23, 2021
@trop trop bot requested a review from miniak September 23, 2021 10:56
@trop trop bot mentioned this pull request Sep 23, 2021
Merged
5 tasks
@trop trop bot added 15-x-y backport This is a backport PR backport/requested 🗳 semver/minor backwards-compatible functionality labels Sep 23, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 23, 2021
codebytere
codebytere approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of @electron/wg-releases on 9/29/2021

@jkleinsc jkleinsc merged commit 4891e92 into 15-x-y Sep 29, 2021
@jkleinsc jkleinsc deleted the trop/15-x-y-bp-feat-add-textwidth-option-to-dialog-showmessagebox--1632394585663 branch September 29, 2021 18:28
@release-clerk
Copy link

release-clerk bot commented Sep 29, 2021

Release Notes Persisted

Added textWidth option to dialog.showMessageBox() / dialog.showMessageBoxSync().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@miniak miniak Awaiting requested review from miniak

Assignees
No one assigned
Labels
15-x-y backport/requested 🗳 backport This is a backport PR semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @jkleinsc @miniak