fix: crash creating private key with unsupported algorithm

[codebytere]

Description of Change

Closes #31064.

Fixed an issue where some calls to crypto.createPrivateKey made with algorithms unsupported by BoringSSL cause a crash when invoking methods on their return values. This was happening because BoringSSL shims some algorithms but doesn't implement them and so attempts to create keys with them will fail (see: evp.h#L835-837)

Node.js returns false in initEdRaw (see crypto_keys.cc#L1106)
but then does nothing with the return value, meaning that if no pkey is created successfully that a key object will still be returned. However, attempts to use the data_ field will crash the process as data_ is never assigned. This is fixed by checking the return value of initEdRaw at the JavaScript level and throwing an error if the function returns false.

cc @deermichel

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed an issue where some calls to crypto.createPrivateKey made with algorithms unsupported by BoringSSL cause a crash when invoking methods on their return values.

[BlackHole1]

I would like to ask a question, why does nodejs 16.4.1 not raise crashes.

In my results, it is correct, e.g:

Does that mean that the problem has been fixed in the new version of the Nodejs code?
If so, why didn't we just bring in the patch for the nodejs fix, instead of introducing a patch we wrote ourselves?

[codebytere]

@BlackHole1 this is outlined in my PR body - Electron uses BoringSSL and Node.js uses OpenSSL. So this will fail in Electron where it would work in Node.js because the underlying crypto libraries differ.

[release-clerk]

Release Notes Persisted

Fixed an issue where some calls to crypto.createPrivateKey made with algorithms unsupported by BoringSSL cause a crash when invoking methods on their return values.

[trop]

I have automatically backported this PR to "16-x-y", please check out #31136

[trop]

I have automatically backported this PR to "15-x-y", please check out #31137