fix: draggable regions in BrowserViews are independent
#31085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron-cation
bot
added
new-pr 🌱
jkleinsc
approved these changes
Sep 29, 2021
|
Release Notes Persisted
|
This was referenced Sep 30, 2021
|
I have automatically backported this PR to "13-x-y", please check out #31197 |
|
I have automatically backported this PR to "15-x-y", please check out #31198 |
|
I have automatically backported this PR to "16-x-y", please check out #31199 |
|
I have automatically backported this PR to "14-x-y", please check out #31200 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #31068
Closes #31052.
After #26145, it was possible to make draggable regions on BrowserViews independent from those of BrowserWindows. As such, if a BrowserView with different draggable regions than the BrowserWindow it belongs to is superimposed on top of that window, the draggable regions of the BrowserView take precedence over those of the BrowserWindow. This is fixed by having each BrowseView update its own draggable regions in
BrowserWindow::UpdateDraggableRegionsinstead of inheriting those coming in fromBrowserWindow::UpdateDraggableRegions.Tested with https://gist.github.com/0a53108546ef22e4d03e1b6dea55a79a and https://github.com/devinbinnie/electron-quick-start/tree/draggable_areas_bv_macos
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where changes to draggable regions in a
BrowserWindowincorrectly affected those in an attachedBrowserView.