fix: first mouse not dragging BrowserView #31062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
approved these changes
Sep 23, 2021
jkleinsc
approved these changes
Sep 23, 2021
|
Release Notes Persisted
|
This was referenced Sep 23, 2021
|
I have automatically backported this PR to "13-x-y", please check out #31098 |
|
I have automatically backported this PR to "14-x-y", please check out #31099 |
|
I have automatically backported this PR to "15-x-y", please check out #31100 |
|
I have automatically backported this PR to "16-x-y", please check out #31101 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Partially addresses #31058.
Fixes an issue where the
DragRegionViewdid not accept the first mouse click, meaning that the first click would only activate the window and not trigger drag behavior immediately as would occur with a BrowserWindow. This fixes the error by ensuring thatacceptsFirstMousereturnsYESforDragRegionView.Tested with https://gist.github.com/0a371fe58ff8c8b72287629ab6d76d34.
Checklist
npm testpassesRelease Notes
Notes: Fixes an issue where out-of-focus BrowserViews could not be immediately dragged.