fix: propagate window.open settings to child window #31031
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
In #24517 and #28518, as part of adding the new
setWindowOpenHandler
API, we refactored the_callWindowOpenHandler
method to pass in additional details and make it more compatible with the new API standard,setWindowOpenHandler
. However, this also broke how feature details were passed into new child/guest windows, specifically ones still usingwindow.open
- if a window was not opened with an existing windowHandler, all child window constructor options would automatically return null, hitting this check.In Electron 14 and 15, two things changed: 1) child windows no longer inherit their transparency settings from parent windows, and 2) our previous default if no background color exists,
SKColor_TRANSPARENT
was converted to an optional valueabsl::nullopt
, which defaults to white. Thus, this bug suddenly surfaced for child windows opened withwindow.open
.This PR allows child windows to fall back on the parsed features to correctly read transparency, background color, etc, until the window.open event is removed.
Checklist
npm test
passesRelease Notes
Notes: Fixed child windows not inheriting the correct transparency and background color settings.